ppy
Add support for ruleset-specific blueprints in editor timeline
RFC. This PR allows rulesets to customize how hit objects are represented in the timeline without having to modify the hit object classes or create additional interfaces. The need for this has been expressed multiple times already in https://github.com/ppy/osu/pull/29441 and https://github.com/ppy/osu/pull/21566
The API is a bit limited because it expects objects of type TimelineHitObjectBlueprint which already defines all the layout and interactions. If more freedom is required, I think TimelineHitObjectBlueprint should not define layout and instead the parts of it should be split into separate classes which could be composited instead.
As an example I've implemented two ruleset-specific changes that make use of this API:
- Sample points at the tail end of spinners
- Disabled timeline in mania (as in stable)
The IHasDisplayColour interface can also be eliminated in favour of taiko specific timeline blueprints.
The above comment notwithstanding I'm gonna need @peppy cross-check on this, since I vividly remember him being vehemently opposed to the notion of per-ruleset deviations of any sort on the timeline, although I cannot find the paper trail for this. I think it must have been somewhere around when we started to implement this editor design. I think it could have been in stream twitch chat or something...?
A couple of screenshot comparisons in the OP would help to explain what this is aiming to achieve. There may be better ways we can do this. I'm hesitant to make the timeline non-generic.
A couple of screenshot comparisons in the OP would help to explain what this is aiming to achieve. There may be better ways we can do this. I'm hesitant to make the timeline non-generic.
I've added a few screenshots and edited images to show what I want to achieve with the timeline.
Thanks. I think it's a valid direction as long as we make sure to keep the UX between rulesets as similar as we can.