ppy
implement replay analysis into spectating
Implements the replay analysis overlay into both solo and multiplayer spectating. For multiplayer spectating, the settings container is added on the left side under the leaderboard. For solo spectating it works the same as watching a replay.
Look of the settings container during multiplayer spectating:
Not sure if parsing new frames during each update instead of all at the beginning means the logic in addEntries should be changed to async now, though I haven't had any performance problems running it.
Also now that it's not all parsed at once, would it be better to limit how far ahead it adds entries for? The purpose being to lessen the initial strain for larger replays being viewed in solo.
Please don't do that until it's necessary.
Didn't plan to; that's why I'm commenting about it.
(this is for multiplayer spectator) The fact that you can change replay analysis from this screen but not visual settings (background dim, beatmap skin...) feels weird, the latter is probably more important than the former (it's diffuclt to see the benefits of analysis in realtime). I think a pop up overlay from the bottom or the right would work better, kinda like stable, if that's not seen as bad UX in lazer (players might want it in solo play too)
I'd say we want to use the standard placement as found in spectator view. The settings can be minimised by default, or they can slide in from the right if even when minimised they are too distracting.
By standard placement do you mean inside the players? or to the right of the player grid?
By standard placement do you mean inside the players? or to the right of the player grid?
Just overlapping the player grid basically. And hopefully not too in-the-way due to being collapsed.