Playlist item display does not account for mods or ruleset conversion when showing star rating

[ziv-vy]

Type

Cosmetic

Bug description

The difficulty shown is not affected by mod multiplier, unlike stable!

Screenshots or videos

Version

2024.731.0-lazer

Logs

compressed-logs.zip

[yesseruser]

The incorrect rating also shows in the room's tile:

[bdach]

@ZenoG2 that's a separate issue, separate issue thread please

[bdach]

This one is sorta difficult to properly deal with because what happens when the user doesn't have the beatmap locally?

I can see two options here:

• somehow get web to return the actual effective star rating including mods
• fix this client-side ourselves, by requesting difficulty attributes from API and doing a local diffcalc

@ppy/team-web any thoughts on this?

[nanaya]

if the data is somewhere in the database then sure, osu-web can pass it along. Last I remember it's only for stable client related mods though? Or have lazer mods also been added?

[bdach]

Yeah nothing has changed on that front, database only contains the attributes for mods that exist in stable.

I wonder if at some point we want osu-rank-lookup-cache to support lazer mods. Maybe that'd be a start to all of this.

[smoogipoo]

I wonder if at some point we want osu-rank-lookup-cache to support lazer mods.

Unless I'm missing a reason, we already have osu-beatmap-difficulty-lookup-cache that's intended for this purpose. I believe it's being forced to use only databased attributes because realtime diffcalc was too expensive (and is why I'm worried about https://github.com/ppy/osu-queue-score-statistics/pull/274) so it doesn't support lazer mods, but it looks like even that would be enough for the OP.

There already is an endpoint for the above somewhere inside osu-web, so perhaps that can be reused.

That said, there's undoubtedly going to be a second problem, which is that star rating is also serialised by the multiplayer client, and likely needs the same (this time unimplemented) solution: https://github.com/ppy/osu/blob/616c2aeefc0f086024e5b3f5130466a21eba3643/osu.Game/Online/Rooms/MultiplayerPlaylistItem.cs#L56-L57

[Qunas101]

Want to chime in and note that this also happens to the new freestyle icon for converted maps, i.e. your friend that the game says is playing an 8* mania map is actually playing a 3*

Spoiler