ppy
When earning multiple medals, only one medal popup is displayed
Type
Cosmetic
Bug description
After trying to earn a hush-hush medal, I accidentally got another medal and ending up getting both after checking my profile but did not know initially due to only the popup for one medal appearing.
Screenshots or videos
Unfortunately, this is difficult to reproduce and I do not have a recording.
Version
2024.727.0-lazer
Logs
I had this happen to me earlier. Specifically Slowboat and Insanity Approaches in my case (although i guess that doesn't matter in this case).
I imagine this would be easiest to reproduce with a new account and clear basically any map with only one mod enabled.
There was a design that was supposed to address this: https://www.figma.com/design/kWr58bjRf9pZWtLFgvn0li/Medal-Unlocked-Screen?node-id=0-1&t=u78TSRtcKx7YcXrw-0
but it and the linked animation were too underwhelming, so the old stable implementation was used, which only makes sense for one medal at a time.
It could also just play the animation again, it doesn't take too long and getting multiple medals at once is obviously pretty rare, at least for now.
The animation is supposed to play again. The code is structured to support displaying multiple medals in succession, and there's even a test case exercising it.
I'm not sure why in these cases it didn't play. It's either an issue with delivery of the notification from web, or some race I didn't account for. Or maybe a case of accidentally dismissing the medal or something early on in the animation?
If anyone encounters this again, please check on the osu! website whether both the notifications arrive or not. This will help us isolate whether this is client-side or web-side.
I've also added some simple logging for the display code, as I can't immediately see an issue with it.
If anyone encounters this again, please check on the osu! website whether both the notifications arrive or not. This will help us isolate whether this is client-side or web-side.
I've also added some simple logging for the display code, as I can't immediately see an issue with it.
My original issue was that the medal popup in the client did not run twice for the two medals (or indicate I earned a second medal at all after playing). I'm not sure about the notifications for the website.
The point is that the notifications on the website and the medal popups in the client use the exact same mechanism of delivery. So if the notifications show on the website but not in client, it's a problem with the client; if they don't show in both places, it's a problem with the delivery mechanism for both.
Acting on this is still relying on new information from someone who reproduces the issue. If this is you, please make sure to check the website to see if both medals appeared there or not, then report back.