osu Remove peak strain reduction

Stops reducing the peak strains in PP. Peak strain reduction is now less needed because combo scaling removal allows for a better balancing of most plays on these maps

Jul 13 '24 03:07 TextAdventurer12

!diffcalc

Jul 16 '24 03:07 smoogipoo

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/9950163812

Jul 16 '24 03:07 github-actions[bot]

!diffcalc

Jul 18 '24 04:07 smoogipoo

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/9985738992

Jul 18 '24 04:07 github-actions[bot]

!diffcalc

Jul 19 '24 04:07 smoogipoo

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/10002753253

Jul 19 '24 04:07 github-actions[bot]

!diffcalc

Jul 19 '24 07:07 smoogipoo

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/10004490955

Jul 19 '24 07:07 github-actions[bot]

This looks very misleading. I think a better way would be to make those fields abstract in OsuStrainSkill and make all skills inheriting it specify it explicitly.

what are you referring to? the intent is to remove reduction at all.. no?

Nov 07 '24 10:11 tsunyoku

This looks very misleading. I think a better way would be to make those fields abstract in OsuStrainSkill and make all skills inheriting it specify it explicitly.

what are you referring to? the intent is to remove reduction at all.. no?

It was only removing custom reduction in Speed before

@TextAdventurer12 please don't add logic changes to merge commits, it's very confusing

Nov 07 '24 10:11 stanriders

Will re-run the spreadsheet generator after conflicts are resolved here.

Nov 07 '24 11:11 smoogipoo

oops I renamed the branch and it closed this PR sorry for the notif, I'll re-pr alongside some other new stuff

Nov 27 '24 13:11 TextAdventurer12