ppy
Change editor speed adjustment back to adjusting tempo
- Partially reverts https://github.com/ppy/osu/pull/12080
- Addresses https://github.com/ppy/osu/discussions/27830, https://github.com/ppy/osu/discussions/23789, https://github.com/ppy/osu/discussions/15368, et al.
The important distinction here is that to prevent misuse when timing, the control will revert to 1.0x speed and disable when moving to timing screen, with a tooltip explaining why.
https://github.com/ppy/osu/assets/20418176/1aa8c616-8e73-4dee-a293-1820716a665e
Is timing at lower speeds accurate if it did only change audio frequency? Maybe we can enable the playback speed in the timing screen if it adjusts frequency instead of tempo there.
Is timing at lower speeds accurate if it did only change audio frequency?
There are have been concerns brought up before like https://github.com/ppy/osu/discussions/27826 or https://github.com/ppy/osu/discussions/26421 which tend to suggest that it might not be. I'm somewhat open to having it stay as a frequency adjustment if those are considered minor.
if it's concluded that timing stays (mostly) accurate with the frequency change then we can definitely have the best of both worlds by keeping the tempo change for compose page (to better identify snaps/rhythms in the song), and having the frequency change in the timing page.
I did a test where I time a 100 BPM metronome as music with different playback speeds in the timing panel. (with frequency change like in master)
I determine the timing offset that sounds on time for each playback speed and then record it at 100% speed with the in-game metronome playing over the music metronome. Lastly I check the recording in audacity to determine the difference in timing between the two metronomes.
Results:
- 25% = my timing is 31ms late
- 50% = my timing is 21ms late
- 75% = my timing is 10ms late
- 100% = my timing is 2ms late
This evidence shows that there is a significant difference in the timing offsets depending on the playback speeds. I guess its fine to disable playback speeds in the timing panel until these offsets are fixed.
Unrelated but interesting: when I use the correct timing, the timeline waveform shows my timing being being quite early.
Unrelated but interesting: when I use the correct timing, the timeline waveform shows my timing being being quite early.
When you say "correct" timing, what is this based on?
Let's give this a try.
I'm waiting for people to complain about the disable in the timing screen, but I can confirm that in its current state it definitely leads to incorrect timings (both master and this PR, but especially this PR).
Unrelated but interesting: when I use the correct timing, the timeline waveform shows my timing being being quite early.
When you say "correct" timing, what is this based on?
With "correct" timing I mean the offset that results in the metronome of the song and the in-game metronome being exactly in sync in the audio recording.