osu icon indicating copy to clipboard operation
osu copied to clipboard

Restart on fail triggered in incorrect mod

Open MingxuanGame opened this issue 1 year ago • 2 comments

Type

Game behaviour

Bug description

I used Sudden Death (Restart on fail: off) and Accuracy Challenge (Restart on fail: on). When SD triggered fail, game restarted.


Reason: https://github.com/ppy/osu/blob/be48377c4c2ab1155f501887021233ce83222d73/osu.Game/Screens/Play/Player.cs#L958-L959

It used AC's setting.

Screenshots or videos

https://github.com/ppy/osu/assets/68982190/a181e71a-1ac7-467c-9722-52e6efb54d79

Version

2024.521.2

Logs

no

MingxuanGame avatar Jun 09 '24 14:06 MingxuanGame

Don't think if this is an issue as it is intentional

BlockHead007 avatar Jun 09 '24 15:06 BlockHead007

I wouldn't say it's intentional. Seems like an oversight to me, but a bit of an annoying one to address (will need to ferry across information which mod specifically triggered the failure).

bdach avatar Jun 10 '24 06:06 bdach