osu icon indicating copy to clipboard operation
osu copied to clipboard

Activate stateful menu items with right-click without closing the menu

Open 424ever opened this issue 1 year ago • 2 comments

  • Closes https://github.com/ppy/osu/issues/10255

This is a feature I first saw implemented in SerenityOS. It is for example usefull, when the user wants to add a beatmap to multiple collections in a multiplayer lobby. menu.webm

424ever avatar May 03 '24 16:05 424ever

I'd prefer this behaviour when right clicking (or adding that in addition to ctrl-click). I don't know where I've seen this done but it feels more natural to me.

Alternatively, make it the always-on behaviour for certain menus.

peppy avatar May 04 '24 07:05 peppy

Searching for right click I also found this issue talking about the same thing: #10255 Where it seemingly was already decided to be handled via right click.

424ever avatar May 04 '24 14:05 424ever

The way this manages to work is a touch haphazard (detailed in inline comment) but I'm willing to let it slide just to get this behaviour in without framework changes.

Will wait for one more review just in case there's any strong objections.

peppy avatar May 06 '24 02:05 peppy