ppy
Show results in results screen based on leaderboard selected in song select
Resolves ppy/osu#26331, resolves ppy/osu#9201.
Now SoloResultsScreen gets scores from LeaderboardScores in Player, similarly to SoloGameplayLeaderboard.
I'm not so sure about how I implemented PopulateScorePanelList in SoloResultsScreen. The idea was that, if the scores are already loaded, then hasLoaded prevents eventual changes that might happen later but still allow delayed fetching of scores (if they somehow didn't have time to load during gameplay and in song select?).
Maybe that can be improved/changed though.
Other thing that changed because of that is the SpectatorResultsScreen, similarly to the GameplayLeaderboard, doesn't show any other scores, because of lack of LeaderboardScores in SoloSpectatorPlayer
edit:
Tests seem to fail due to changing of testResults, even though on my local machine dotnet test gives 0 fails.
Are the tests performed parallelly and in normal situation it wouldn't occur, or just logic in SoloResultsScreen is not thread safe?
I'm personally deprioritising further review of this as it was discussed during today's catch-up meeting that the future of the leaderboard on the results screen is not certain (it may even be that the results screen won't fetch other results at all anymore).
