osu icon indicating copy to clipboard operation
osu copied to clipboard

Treat misses and sliderbreaks equally in accuracy for osu! difficulty calculations

Open Finadoggie opened this issue 1 year ago • 6 comments

Currently, misses and sliderbreaks are generally treated as the same in pp, but misses drop accuracy slightly more than sliderbreaks, leading to misses being slightly more punishing for no real reason. By treating misses as 100s, misses and sliderbreaks will be treated the same in terms of accuracy.

Misses will still be significantly more punishing than 100s or 50s on circles and spinners for obvious reason, this only affects the relation between misses and sliderbreaks

(this makes very little difference on master currently, really only affecting high misscount plays, and matters more for any future PRs which aim to shake up how misses and combo are handled)

Finadoggie avatar Mar 21 '24 23:03 Finadoggie

!diffcalc

smoogipoo avatar Mar 22 '24 07:03 smoogipoo

Target: https://github.com/ppy/osu/pull/27690 Spreadsheet: https://docs.google.com/spreadsheets/d/1wvmJhDDEv2EDFRqCFGvfF4z-Ivi93n_CwXQ2rmyVMVU/edit

github-actions[bot] avatar Mar 22 '24 07:03 github-actions[bot]

It appears I did not account for slider-only maps…

Finadoggie avatar Mar 22 '24 16:03 Finadoggie

might revisit that later, for now I'm just gonna keep this commit to be just the thing that hopefully works

Finadoggie avatar Mar 23 '24 00:03 Finadoggie

!diffcalc

Finadoggie avatar Mar 23 '24 00:03 Finadoggie

Target: https://github.com/ppy/osu/pull/27690 Spreadsheet: https://docs.google.com/spreadsheets/d/1w97-02hOu7Zj_3j0tINImPEpAn5xUMSzIM5qDAGOB84/edit

github-actions[bot] avatar Mar 23 '24 00:03 github-actions[bot]

isn't it's better to just ignore misses when calculating accuracy? like stat acc is doing

Givikap120 avatar May 25 '24 22:05 Givikap120

isn't it's better to just ignore misses when calculating accuracy? like stat acc is doing

I chose not to do this since doing that creates scenarios where sliderbreaking is more punishing than missing and I think that’s dumb

In Lazer scores, I would advocate for ignoring misses in acc, I just haven’t gotten around to that yet

Finadoggie avatar May 27 '24 20:05 Finadoggie

isn't it's better to just ignore misses when calculating accuracy? like stat acc is doing

I chose not to do this since doing that creates scenarios where sliderbreaking is more punishing than missing and I think that’s dumb

In Lazer scores, I would advocate for ignoring misses in acc, I just haven’t gotten around to that yet

well, you can subtract sliderbreaks from 100s by doing this countOk -= effectiveMisscount - countMiss;

Givikap120 avatar May 27 '24 22:05 Givikap120

gonna close this for now since it's both incredibly minor and superceded by stat acc

Finadoggie avatar Jul 03 '24 19:07 Finadoggie

superceded by stat acc

I don't think this is a good motivation considering stat acc hasn't been anywhere near completion for years. Its not superceding anything until its in a good enough shape

stanriders avatar Jul 04 '24 10:07 stanriders

superceded by stat acc

I don't think this is a good motivation considering stat acc hasn't been anywhere near completion for years. Its not superceding anything until its in a good enough shape

stat acc is practically ready

Givikap120 avatar Jul 04 '24 11:07 Givikap120

reopening this cause I didn’t realize it was pending deploy

(I was under the impression that it was awaiting review, and thought it just wasn’t worth the resources with how minor it is)

((it still vanishes once stat acc is implemented))

edit: wait I'm stupid, closing it apparently changed its status on the project lol

Finadoggie avatar Jul 04 '24 17:07 Finadoggie