osu icon indicating copy to clipboard operation
osu copied to clipboard

Watching a replay does not show leaderboard

Open peppy opened this issue 1 year ago • 0 comments

The cause is lack of scores bindable hookup to LeaderboardScores in the following flows:

https://github.com/ppy/osu/blob/85364d25dc8709da58225ebc36469e8d15ee265a/osu.Game/OsuGame.cs#L764-L770

compared to flows which see the Player initialised by song select:

https://github.com/ppy/osu/blob/0074bdc5a17be66df7dd656106973829e0909bc8/osu.Game/Screens/Select/PlaySongSelect.cs#L132-L142

Very painful, also related to https://github.com/ppy/osu/pull/26520 / https://github.com/ppy/osu/pull/26410.

I think we either need a global component to handle leaderboard retrieval / provisioning, or it needs to be queried a second time inside of Player isolated from the song select querying. Likely the former due to results screen also needing to consume the scores?

peppy avatar Mar 14 '24 08:03 peppy