osu icon indicating copy to clipboard operation
osu copied to clipboard

Leaderboard still visible on outdated loved/ranked maps

Open 0x84f opened this issue 1 year ago • 5 comments

Type

Other

Bug description

If you downloaded a beatmap set before its status changed, the ranked/loved leaderboard is displayed even though the set or only one difficulty needs to be updated, which is misleading because it appears as if the map is ready to play.

In stable if a beatmap set (or just one difficulty of the set) is updated after downloading, the map will change its status to be "not submitted" or ask for an update to be pulled via a button where the leaderboard would sit

Screenshots or videos

image As per the above example the highlighted difficulty is the only one that's giving the beatmap_hash error, but the leaderboard is still displaying which is misleading

Version

2024.302.1-lazer

Logs

n/a

0x84f avatar Mar 11 '24 14:03 0x84f

after a discussion with spaceman this should probably be a discussion and not an issue

0x84f avatar Mar 13 '24 17:03 0x84f

I left this be for a reason. In fact I am trying to make this happen right now.

bdach avatar Mar 13 '24 17:03 bdach

I thought this was going to be a nice old 20 minute feature. Oh how wrong I was. Why, you ask? Because song select is a scourge.

As it turns out, when you update a beatmap, sure it gets invalidated from WorkingBeatmapCache, and sure it gets updated on the carousel. But as far as I can tell, the rest of song select happily continues to use the invalidated working beatmap. Which means that the rest of song select - including the leaderboard - doesn't react to the beatmap update at all.

If you think I'm missing something here's a branch to test on if so inclined: https://github.com/ppy/osu/compare/master...bdach:osu:leaderboard-visible-outdated. Without the last commit the update will work on the carousel but not on the left side of song select. With the last commit it will work but only after the first time (haven't figured that out yet and don't want to get lost in this today.)

@ppy/team-client for your information because this is pretty major. thoughts and advice appreciated.

bdach avatar Mar 13 '24 18:03 bdach

To confirm this is a temporary display bug with the leaderboard (and other components) which resolves on revisiting the main menu?

peppy avatar Mar 13 '24 23:03 peppy

I'm not sure I was intending it to be temporary because hiding song select leaderboard is a thing on stable. But everything else checks out I suppose.

bdach avatar Mar 14 '24 04:03 bdach