osu icon indicating copy to clipboard operation
osu copied to clipboard

Add pp and playtime to the `UserRankPanel`

Open stanriders opened this issue 1 year ago • 7 comments

Relevant figma design (not matching 100%, was taken as inspiration): https://www.figma.com/file/ocltATjJqWQZBravhPuqjB/UI%2FPlayer-Card?type=design&node-id=42-1189&mode=design&t=lr0a8PR9pPC0mCUK-0

image

Something I should've done in the first PR honestly. I'd say this is as much info as this panel can fit without looking messy

stanriders avatar Feb 12 '24 19:02 stanriders

I'm not sure how to feel about the pp count being added where you have it given I had been just working on something to show pp count after every play a few days ago. There's also https://github.com/ppy/osu/pull/27128 and https://github.com/ppy/osu/pull/27107 which touch the same places.

Way too crowded up in here.

bdach avatar Feb 13 '24 12:02 bdach

I wouldn't say any of those PRs are mutually exclusive with this one, and imo the only one that's even related to this one is https://github.com/ppy/osu/pull/27128 since https://github.com/ppy/osu/pull/27156 is a notification type of thing while this is always available data and https://github.com/ppy/osu/pull/27107 is in the completely different place (user overlay) and doesn't affect UserRankPanel at all

I don't think this PR is high priority in any way though so it can stay blocked until the statistics watching refactoring is in

stanriders avatar Feb 13 '24 14:02 stanriders

I agree that the two aren't mutually exclusive.

smoogipoo avatar Feb 14 '24 04:02 smoogipoo

Spacing on this looks a bit dodge:

1707915261 1707915597

The total playtime is a touch long there. And it's not exactly just a case of outlandish data either, we have actual users that have played that much.

bdach avatar Feb 14 '24 12:02 bdach

I've noticed the rank can overflow on 7+ digits as well - I'm not sure how to go about fixing it, making fonts smaller is an obvious solution, but profile data classes already have a small option and adding something like medium sounds ugly and making user rank panel wider will probably need login panel design adjustments

stanriders avatar Feb 14 '24 14:02 stanriders

Making wider is probably easiest. I'm not sure that panel needs any design adjustment other than "make wider". Layout seems pretty simple there.

bdach avatar Feb 14 '24 15:02 bdach

I'd argue shit is all over the place. There's 4 different font sizes on the panel. the headers are the same colour while the content beneath the headers differs in colour. "pp" is lower case.

everything feels wonky, and the panel feels like it's going to topple over to the right.

@arflyte please fix/advise.

peppy avatar Feb 14 '24 19:02 peppy

I would prefer playtime in hours, it's much more readable than days

Givikap120 avatar Feb 22 '24 12:02 Givikap120

It matches the profile overlay. If it's to change it should change in both places. And web.

Chances are it'll have hours as a tooltip anyhow (because profile overlay does).

bdach avatar Feb 22 '24 12:02 bdach

image It does have a tooltip since it reuses profile overlay's element

stanriders avatar Feb 22 '24 13:02 stanriders