Allow pp for muted mod for any combination of settings

[cdwcgt]

• Adressed https://github.com/ppy/osu/discussions/27130

ModMuted was enable ranked in https://github.com/ppy/osu-queue-score-statistics/pull/9 the reason is "it doesn't change gameplay" so can we make ModMuted ranked when adjust settings

[smoogipoo]

I'm not ready to merge this until one full SR/PP recalc using lazer's processor has completed.

[stanriders]

Muted isn't being accounted for in sr/pp at all, so it shouldn't affect difficulty unless there's something fundamentally broken

[bdach]

until one full SR/PP recalc using lazer's processor has completed

I'm not sure why this is a requirement if it wasn't for https://github.com/ppy/osu/pull/26935.

Or why the mod was enabled at all in the first place even, if this is somehow a concern.

[stanriders]

I'd say blinds was more important to test than this indeed, since it actually affects pp

[bdach]

I did do a quick-and-dirty test for blinds locally and it did appear to work correctly.

[Givikap120]

I'd say metronome is a tiny bit easier to click to on some maps, but after testing I couldn't find any way to use it to my advantage because it quickly gets muted and replaced with the song on any combo settings and any miss throws you off way more than you get from the metronome at the start of the map. So yeah, I'd say its fine to have all settings ranked

if you think that metronome can create advantage - think about possibility of mp3 editing i don't think anyone should care about it

[bdach]

Note: will require game package bump and deploy in osu-queue-score-statistics.

[cdwcgt]

https://osu.ppy.sh/scores/2326779201

this score is set before this pr merged (deployed), and it is marked as not giving pp Will the scores before mod ranking settings be updated not be calculated into pp?

[bdach]

Will the scores before mod ranking settings be updated not be calculated into pp?

I don't think that was explicitly stated anywhere but we didn't promise anywhere that they will be, so I guess the de facto answer is no. As of now scores begin to count for pp only after a mod becomes officially ranked (the change ranking them is deployed).