osu icon indicating copy to clipboard operation
osu copied to clipboard

Published 20 hours ago • verified publisher icon ppy

Add highest rank tooltip to global rank display

Open Joehuu opened this issue 1 year ago • 2 comments

this PR Web
Screenshot 2024-02-09 at 3 56 49 PM Screenshot 2024-02-09 at 3 55 32 PM

Joehuu avatar Feb 10 '24 00:02 Joehuu

Are you willing to back out the GlobalRankDisplay changes for now? I'm reluctant to merge this without that, because the lack of correct updating flows there is inevitably going to lead to things looking weird.

bdach avatar Feb 19 '24 12:02 bdach

Yeah will do, wasn't worth centralizing when the LoginOverlay usage was not updating correctly, to begin with.

Joehuu avatar Feb 19 '24 19:02 Joehuu