ppy
Verification form localisation broken
Type
Other
Bug description
I was greeted by an email verification prompt when I tried to login to lazer just now, and while the verification itself went fine, I noticed that the email that I got didn't match the language in which I'm using my lazer on (Indonesian).
I was expecting the email to be sent in Indonesian as well, as it is the case with the emails sent from the osu.ppy.sh website, but apparently the game client still defaults the language to English in this case (Image #1).
On another note, I also noticed that the email verification prompt in lazer by itself is still written in a mish-mash of languages (Image #2), although I figured that this probably has more to do with certain strings from web not being fully integrated with lazer yet.
Screenshots or videos
(Image #1)
(Image #2)
Version
2024.131.0
Logs
(n/a)
@ppy/team-web How would one even control the language in which this email is sent? Is this doable via API?
On another note, I also noticed that the email verification prompt in lazer by itself is still written in a mish-mash of languages
See
https://github.com/ppy/osu/blob/7f3646f2d1f4ee6a2d3e6c17ac49fe611304951f/osu.Game/Overlays/Login/SecondFactorAuthForm.cs#L97
it already uses user language (osu-web side, that is)
also fwiw op has their language set to en which is why the email is in en
I guess that part is working as intended then.
Changing title to just track the broken translation.
well, game client currently doesn't use osu-web's user language settings so there's that. I think rather than being able to specify the mail language in api, it may be better to have the language synchronised with osu-web? I don't think the endpoint to set it exists at the moment though
I guess we could do that, but one thing that may be an issue is that client does not support all languages yet that web does (and likely will not for a long time). I'm not sure when (if ever) we'll be able to support right-to-left scripts etc. which are not that much of an issue in a web environment.
also fwiw op has their language set to en which is why the email is in en
OH YEAH i forgot lol, i've been using Indonesian for like 99% of the time but back then i momentarily switched to en because i was working on this and i needed to cross-check something 😔
it's interesting tho still, i never expected that the email would follow the user's web locale instead of lazer locale...