Remove confirmation when game is asked to be restarted by the user

Open peppy opened this issue 1 year ago • 2 comments

Opening this as a draft to figure out direction with this. Arguably SessionStatics is not the correct place for the flag, and it should live in OsuGame. I'd keep it in the parameters alone but it's hard to get the message to MainMenu as part of the OnExiting flow.

Will add tests once a direction is agreed upon.

This is low priority.

All game restart requests are triggered via user intent, so they shouldn't require confirmation.

Addresses https://github.com/ppy/osu/discussions/25826#discussioncomment-7894797.

Jan 16 '24 05:01 peppy

I guess bump to @ppy/team-client on this one, I think it's still good to go ahead if the direction of using SessionStatics is agreed upon 😄 .

Apr 16 '24 02:04 peppy

The SessionStatics usage is not the prettiest but given the previous attempts at this I'm not sure I'm wanting to fight that too much.

Apr 16 '24 09:04 bdach