osu icon indicating copy to clipboard operation
osu copied to clipboard

Add user card with global/country ranks to login overlay

Open stanriders opened this issue 1 year ago • 1 comments

Part of https://github.com/ppy/osu/issues/22130, closes #2510

  • [ ] Requires https://github.com/ppy/osu/pull/26356

I'm aware that unexpected PRs like this are not really welcomed, but I believe lack of quick way to see your rank is something that people will complain a lot about after pp release, though you can throw it into the backlog if you think it's not that important.

Design is a combination of current user card with expanded user card view from figma. I think it's good enough as a temporary solution and proper design can be implemented whenever design for the new user cards gets finalized.

image

stanriders avatar Jan 02 '24 14:01 stanriders

Code quality failing

bdach avatar Jan 02 '24 15:01 bdach

Okay so I went to repair this but it turns out you've opened a can of worms. Specifically that ExtendedUserPanel's Status and Activity likely should not exist. And you'll need to resolve the conflict, aka. fix the fact you're not using that panel type anymore.

peppy avatar Jan 15 '24 09:01 peppy

Yep I wasn't pushing changes here until https://github.com/ppy/osu/pull/26356 merge, will fix stuff up now. As for the ExtendedUserPanel I too thought that it's a weird design, but doing something about it would be out of scope for this PR

stanriders avatar Jan 15 '24 10:01 stanriders