Refactor classic osu!catch combo counter and place it in HUD overlay
- [x] Depends on https://github.com/ppy/osu/pull/26249
Also adjusted vertical position of legacy catch combo counter to roughly match stable (basically center).
"Closest" anchor is disabled for the combo counter since using an anchor that's not on the left side will break the calculation of the X position (also X position is calculated automatically so it doesn't make sense to change the anchor rather than locking it).
Preview:
https://github.com/ppy/osu/assets/22781491/e3a87d2b-767e-449b-a91d-ea586a4dfd34
Android project compile failures here
I've brought this up-to-date. Probably needs second eyes at some point (low priority I guess), since I was involved in making this bearable.
I've removed LegacyComboCounter again, but I've stumbled across a very harsh bug caused by "floating fruits" mod.
Since the combo counter is no longer tied to the drawable ruleset, it will not be flipped alongside the catcher and all other components without hacks implemented. I've tried to handle this in https://github.com/ppy/osu/pull/26253/commits/cfc8b78feaba5ef7c5783c8e8f90d5c005b6326a but the implementation is quite unbearable, especially since I've came to realise this PR is purely a code-quality refactor with the small addition of allowing the combo counter to be moved vertically.
I personally think it is a better choice to close this PR and revisit it later when rulesets are allowed to create their own skinnable containers (so that we can have a "Catcher" layer that moves alongside the catcher and is flipped accordingly, combined with UprightAspectManintaingContainer to keep the content of the counter upright).
Closing as such. Can be reopened if anyone thinks otherwise.