osu Merge 1-10K mods into a single "Key Count" mod

another attempt at #25505, closes #25252

069053b3afa57edabee524497ec54830258de47b is my attempt to convert the previous mod acronyms into something useful, but I'm not sure if this is the right way to go about it. and I have not tested this with the full web stack yet but I suspect things will break there...

I am also not confident that my changes to DifficultyAdjustmentMods for the diff calculator are correct, because I haven't checked to see how those are used in other projects yet

Dec 17 '23 08:12 cl8n

I'll just say that this merging of key mods has infrastructural concerns that will need handling in server side components and probably also web. Thus, I am personally not reviewing it this year as I consider it largely unimportant in the scale of everything.

Dec 17 '23 09:12 bdach

:ok_hand: no rush. I'll take a look into the server implications myself in the meantime, I'm just not confident I will be able to propose a good fix there if it gets complicated

Dec 18 '23 08:12 cl8n

For starters:

https://github.com/ppy/osu-queue-score-statistics/blob/b58b50598db10081b1e27579e194bb9262001837/osu.Server.Queues.ScoreStatisticsProcessor/Processors/ScorePerformanceProcessor.cs#L160-L166
osu-difficulty-calculator should actually just work
web display (key mods have separate leaderboards per key, so there's the whole smorgasbord of what's going to happen to indexing, to display, etc etc) - this is probably the single biggest issue here

Dec 18 '23 08:12 bdach