osu icon indicating copy to clipboard operation
osu copied to clipboard

Difficulty Adjust options show "reset to default" button even when at default values

Open Purpal7 opened this issue 2 years ago • 3 comments

Type

Cosmetic

Bug description

The mod customisation options for Difficulty Adjust still show the "reset to default" button even when at default values. This only occurs after the sliders have been moved; when the mod customisation tab is first opened, the "reset to default" buttons are absent (as intended).

Screenshots or videos

https://github.com/ppy/osu/assets/75558066/177362ef-469b-4e2b-99b8-cfef561c453c

Version

2023.1130.0-lazer

Logs

network.log performance.log performance-audio.log performance-draw.log performance-input.log performance-update.log runtime.log updater.log database.log input.log legacy-ipc.log

Purpal7 avatar Dec 16 '23 04:12 Purpal7

Probably intended to lock/override circle size to 3.8 (as shown in the video).

I believe this can be fixed visually by replacing the icon with a https://fontawesome.com/icons/unlock?f=classic&s=solid and adjusting the tooltip accordingly (to "unlock").

Joehuu avatar Dec 16 '23 21:12 Joehuu

Probably some more floating point stuff going on here I think

longnguyen2004 avatar Dec 17 '23 03:12 longnguyen2004

@Joehuu is correct. @longnguyen2004 is not.

Once you manually set a DA setting it remains locked there if you switch to another beatmap. So it's not a "default" setting of the mod which means "use beatmap's value".

That is by design, so this is a UX concern.

bdach avatar Dec 17 '23 09:12 bdach