osu icon indicating copy to clipboard operation
osu copied to clipboard

Apple Smart keyboards and trackpads no longer work on SDL iPadOS

Open Jed666 opened this issue 2 years ago • 13 comments

Type

Game behaviour

Bug description

keyboards that connect through the smart connector on the located on the left side in portrait orientation on ipads no longer work except for text input, with the trackpad semiworking but still broken, registering one click as two clicks and the native ipad cursor appearing overlaid ontop of the osu cursor. (also right clicks dont work but i think thats a problem with smart connector keyboards in general, so i also request control clicks be added (control clicks work outside of osu fyi)

System infomation: iPad 9th gen (iPadOS 16.4.1) Logitech Combo Touch (with latest firmware (v00.13-00.12)

apologies if this is written badly.

Screenshots or videos

IMG_0624 https://youtu.be/M9_r-fZH4qo

Version

2023.326.0 and later.

Logs

cant show log files cause itunes wont cooperate.

Jed666 avatar Apr 23 '23 06:04 Jed666

should have said this earlier but it worked perfectly in older versions. (other then right click)

Jed666 avatar Apr 23 '23 06:04 Jed666

last compatible ver: 2023.305.0 IMG_0625 https://youtu.be/0osR-QXTsRg

Jed666 avatar Apr 23 '23 06:04 Jed666

Since 2023.326.0, we've transitioned to using SDL for iOS, which means relying on their input handling implementation.

Hardware keyboard not working is currently tracked on their side at https://github.com/libsdl-org/SDL/issues/6465. Check if doing as mentioned in https://github.com/libsdl-org/SDL/issues/6465#issuecomment-1306318213 fixes the issue for you.

As for the trackpad issue, I'll need logs to further investigate this.

frenzibyte avatar Apr 24 '23 00:04 frenzibyte

finally got logs. these logs are from the most recent release as of writing this.

network.log performance.log runtime.log database.log input.log

Jed666 avatar May 18 '23 04:05 Jed666

Hmm, unfortunately, logs don't show anything useful as-is, I'll need someone on the team able to reproduce this and investigate further (cc @peppy).

frenzibyte avatar Jun 04 '23 18:06 frenzibyte

The keyboard portion of this has been fixed upstream in SDL: https://github.com/libsdl-org/SDL/commit/f5ea6ae18d860796184b9b31a2005957cb7e30a2

After testing with a Logitech Combo Touch, I cannot reproduce the aforementioned double click issues (2023.717-0).

The cursor and ~~right click~~ issues are still present (should possibly be a different issue as they are not related to hardware keyboards necessarily?)

NiceAesth avatar Aug 02 '23 08:08 NiceAesth

in regards to the right click, on attempt on using it in other areas on my my ipad with the keyboard, i havent been able to use the function whatsoever.

but. with a bluetooth mouse connected (also by logitech if that matters), it has been working perfectly even within osu! itself so the right click issues are probably an issue with the combo touch itself.

i dont know if the right click is just broken on my combo touch, or if it affects everyone of them, but taking niceaesth’s comment into mind, id assume it affects all of them.

further testing may be required.

Jed666 avatar Aug 02 '23 13:08 Jed666

Right click is functional, tested again. You have to click with two fingers to activate it. (Where you click on the trackpad is irrelevant)

Two finger scroll is a bit iffy since it is very very fast

NiceAesth avatar Aug 02 '23 18:08 NiceAesth

ahh i see, didnt know it had to be done that way (im used to windows trackpads).

im having the same issue with two finger scroll aswell.

Jed666 avatar Aug 03 '23 03:08 Jed666

I guess we might just need an SDL bump to fix this? First we'd want to confirm we haven't already bumped SDL since the reported fix

peppy avatar Dec 18 '23 08:12 peppy

I think we close this for now and hope this is fixed with SDL3.

smoogipoo avatar Apr 24 '24 06:04 smoogipoo

Tested on latest release, can confirm it works

NiceAesth avatar Apr 27 '24 15:04 NiceAesth