osu icon indicating copy to clipboard operation
osu copied to clipboard

Beatmap imports using the local cache lookup do not get a submitted / ranked date populated

Open Loreos7 opened this issue 2 years ago • 7 comments

Type

Game behaviour

Bug description

(Title). Works the same with Date Ranked sorting criteria.

Beatmap: https://osu.ppy.sh/beatmapsets/25861#osu/92939

Screenshots or videos

https://user-images.githubusercontent.com/86934170/214570836-893e45fd-7c0e-471c-bcf6-ebd396c5796e.mp4

Version

123

Logs

Loreos7 avatar Jan 25 '23 13:01 Loreos7

I can see said beatmap even with the date submitted sorting image

But i'm more curious on why at the end of the video the game seems to show every beatmap you have as updateable?

Also, you should've posted logs, as requested in the issue template

Theighlin avatar Jan 25 '23 14:01 Theighlin

@Theighlin This is due to https://github.com/ppy/osu/discussions/19551 Logs are network.log runtime.log performance.log updater.log database.log

Loreos7 avatar Jan 25 '23 14:01 Loreos7

The issue was resolved by deleting online.db file.

Loreos7 avatar Jan 25 '23 15:01 Loreos7

The issue was resolved by deleting online.db file.

I'm... not sure that is an acceptable fix. Do you recall how the map might have been imported?

These symptoms may indicate that there's a gap somewhere in the metadata population flow that we may need to address.

bdach avatar Jan 25 '23 16:01 bdach

@bdach You're right. I can reproduce this issue again. I downloaded the beatmapset through the web, imported to osu!stable client, then imported it through Setup wizard in lazer.

https://user-images.githubusercontent.com/86934170/214722602-757f14ac-6be7-42f7-ba4b-973e3af9ef16.mp4

Loreos7 avatar Jan 26 '23 00:01 Loreos7

https://github.com/ppy/osu/blob/27c497145f87449ac17c08796fc57026d3129f2e/osu.Game/Beatmaps/BeatmapUpdaterMetadataLookup.cs#L233

To make this work, the local lookup database needs osu_beatmapsets in addition to osu_beatmaps.

peppy avatar Jan 26 '23 07:01 peppy

I think the problem is if importing multiple beatmaps into osu!lazer at once, for example importing a bunch of beatmaps from osu!stable or dragging and dropping multiple osz into osu!lazer. osu!lazer will automatically skip the process of sorting by date summitted and date ranked, making date summitted and date ranked sort by date added.

If download beatmaps from within osu!lazer itself, osu!lazer can check-in and sort each beatmap according to date summitted and date ranked.

I remember that this error did not occur before June 2023, but after that version it occurred

huyenden avatar Mar 14 '24 17:03 huyenden

Not sure whether this counts as this issue or other one Sorting by Date ranked, Date submitted and Date added doesnt seem to work at all for maps imported from stable.

Video for reference: https://streamable.com/0w1r6w Gamever: 2024.817.0-lazer 1724241695.performance.log 1724241695.database.log 1724241695.updater.log 1724241695.runtime.log 1724241695.network.log

StarBleu1 avatar Aug 21 '24 12:08 StarBleu1

It'll be invariably caused by this issue, yes.

bdach avatar Aug 21 '24 12:08 bdach

Not sure whether this counts as this issue or other one Sorting by Date ranked, Date submitted and Date added doesnt seem to work at all for maps imported from stable.

For 2 years now I still think this is the biggest bug because the most useful lazer function which is date ranked doesn't work properly because of importing maps from Stable.

One of the ways I used to fix the error is https://github.com/molneya/osu_db_helpers. To update date added in stable to date ranked. Then enter map in lazer.

This way will bypass the error that causes lazer to still record date ranked as date added. But still can not avoid the original error.

Hope @bdach considers.

huyenden avatar Aug 21 '24 12:08 huyenden