osu icon indicating copy to clipboard operation
osu copied to clipboard

osu!mania Argon skin doesn't work with timing-based note colouring

Open smoogipoo opened this issue 3 years ago • 6 comments

Type

Cosmetic

Bug description

Triangles Argon
image image

Screenshots or videos

No response

Version

bdc6755ee207ae535c3da441bb4c9270b50eb957

Logs

smoogipoo avatar Oct 28 '22 03:10 smoogipoo

Bumping in priority since this is pretty broken.

We could either

  • Replace the note colour (usually taken from the column)
  • Only colour the white pieces (the line at the bottom and the symbol)

Interested in more opinions on this.

We should also consider migrating the setting to the "Synesthesia" mod if this is a considerable change.

peppy avatar Jun 21 '23 04:06 peppy

the skin could be made to detect when the timing based coloring is enabled and make the notes become white instead of colored so that the timed colorings pop out much better. the glow when the notes get hit could also be colored to the note's color too.

LOLZSICKA avatar Nov 17 '23 02:11 LOLZSICKA

the skin could be made to detect when the timing based coloring is enabled and make the notes become white instead of colored so that the timed colorings pop out much better. the glow when the notes get hit could also be colored to the note's color too.

This is mentioned directly above:

Replace the note colour (usually taken from the column)

peppy avatar Nov 17 '23 03:11 peppy

@arflyte did you end up coming up with a way to show this on the argon skins?

peppy avatar May 04 '24 07:05 peppy

Need a lil bit more explanation. I'm not so sure, but is this regarding the colour of the long bars when activated?

arflyte avatar May 06 '24 06:05 arflyte

The notes, long note heads and tails look broken when timing-based note coloring is turned on, and some design is needed to properly adapt timing-based note coloring to Argon. My personal preference is to:

Replace the note colour (usually taken from the column)

with a color based on the timing of a note, but potential contrast problems are noted given the columns having different colored backgrounds.

mcendu avatar May 07 '24 07:05 mcendu