osu icon indicating copy to clipboard operation
osu copied to clipboard
verified publisher icon ppy

Fix "note lock" shake not always animating

Open peppy opened this issue 3 years ago • 0 comments

This was an implementation detail to ensure the shake did not factor in to hit detection. I've moved the containers local in DrawableHitCircle and DrawableSlider and ensured the hit detection containers are not affected.

As seen in https://github.com/ppy/osu/discussions/20223#discussioncomment-3648986

Can be tested using TestSceneObjectOrderedHitPolicy

Before:

https://user-images.githubusercontent.com/191335/191669308-303c469f-aa11-4ea8-9766-4aec58e77eec.mp4

After:

https://user-images.githubusercontent.com/191335/191669554-facd10f3-1ce5-4fbf-a0ac-f161b4255e56.mp4

peppy avatar Sep 22 '22 06:09 peppy