osu icon indicating copy to clipboard operation
osu copied to clipboard

Published 20 hours ago • verified publisher icon ppy

Slider follow circle disappears after changing beatmap properties

Open smoogipoo opened this issue 2 years ago • 1 comments

Discussed in https://github.com/ppy/osu/discussions/20128

Originally posted by Feodor0090 September 5, 2022 Not sure how to explain it properly.

https://user-images.githubusercontent.com/53872073/188335235-f13fe7cd-3c6a-406a-9cfb-d00bedb3e919.mp4

Steps:

  1. Create a beatmap / start editing one.
  2. Place a very long slider.
  3. Be in it's middle.
  4. Change beatmap's CS on "setup" tab.
  5. Return to compose tab, try to seek a little
  6. Notice that followcircle disappears at moment where you was when changing CS.

smoogipoo avatar Sep 05 '22 02:09 smoogipoo

Tentatively assigning as I've started work on this, but not sure if I'll see it through to fruition.

Basic gist is that this transform code is being run at the current point in time when ApplyDefaults is called, clobbering any animations:

https://github.com/ppy/osu/blob/c2c2c505a4f2ab578afaff235e3c042e1e42bf00/osu.Game.Rulesets.Osu/Skinning/FollowCircle.cs#L53-L57

peppy avatar Sep 06 '22 03:09 peppy