osu icon indicating copy to clipboard operation
osu copied to clipboard

Editor change handling should be simplified

Open peppy opened this issue 2 years ago • 0 comments

Right now, editor changes can be signalled via EditorBeatmap.BeginChange or IEditorChangeHandler.BeginChange.

Each of these have slightly different behaviour. And one calls the other. Kind of.

It's all a bit convoluted.

There should only be place to signal these changes, and if both are to exist one should forward to the other.

As noticed in https://github.com/ppy/osu/pull/19984#pullrequestreview-1091283479

peppy avatar Aug 31 '22 04:08 peppy