osu icon indicating copy to clipboard operation
osu copied to clipboard

SignalR connections shouldn't be terminated on main API failure

Open peppy opened this issue 3 years ago • 0 comments

I don't think is is required these days. SignalR's connection has its own resilience logic and I think we have most flows correctly handling API failures in a way which doesn't require the signalr connection to be dropped (ie. multiplayer room creation).

Discussed in https://github.com/ppy/osu/discussions/19415

Originally posted by mty22 July 27, 2022 Scenario: 2 players in lobby, one was spectating and one was playing (myself).

Mid way through map, we were forcefully booted from the lobby into the main menu.

Build: 2022.723.0-lazer

Issue can be observed in runtime.log at 2022-07-27 10:27:19

I'd love to add more context to this report, although I don't believe there's much more that I can add. osu!lazer notified that there was an unhandled exception (which was reported) after landing on the main menu.

database.log network.log performance.zip runtime.log updater.log

Thanks! frzn / frznmatt.

peppy avatar Aug 01 '22 16:08 peppy