osu icon indicating copy to clipboard operation
osu copied to clipboard

Sort by Date Ranked hides supposedly ranked beatmaps

Open FriendsNone opened this issue 2 years ago • 16 comments

Type

Other

Bug description

Correct me if I'm wrong. Sort by Date Ranked should sort beatmaps by when it was ranked. But in this case, it just hides all the supposedly ranked maps.

I'm not sure if this is due to most of my beatmaps are imported from stable.

Screenshots or videos

Windows:

https://user-images.githubusercontent.com/4056272/182009795-be4f7387-adf8-43d6-8adc-9955703edbd2.mp4

Android:

https://user-images.githubusercontent.com/4056272/182010155-6fb49391-e0e3-4e30-b4a7-0e3d446906ae.mp4

Version

2022.731.1 on Windows 11 and 2022.723.0 on Android 12

Logs

Windows network.log performance.log runtime.log updater.log database.log legacy-ipc.log

Android runtime.log performance.log network.log database.log

FriendsNone avatar Jul 31 '22 04:07 FriendsNone

Can you please attach your client.db

peppy avatar Jul 31 '22 06:07 peppy

client.realm.gz Here, I'm having the same problem. Those beatmaps where just downloaded on a new client save. Most BeatmapSets don't have both DateSubmitted and DateRanked. Those are also different from my other save: Willi wills wissen had both dates on my main save but when i just downloaded it, it didn't have any.

naipofo avatar Jul 31 '22 10:07 naipofo

Have you always been logged into the game and have a network connection available?

peppy avatar Jul 31 '22 10:07 peppy

Yeah

naipofo avatar Jul 31 '22 10:07 naipofo

Can you please attach your client.db

Got back from somewhere. I'd assume you mean client.realm? This is from the Windows machine. I can send the one on Android if needed. client.zip

If that's not it, Then I couldn't find client.db within the osu folder

FriendsNone avatar Jul 31 '22 10:07 FriendsNone

It seems like downloading qualified maps always fetches them with DateRanked and the few ranked maps i had working where downloaded before as qualified.

naipofo avatar Jul 31 '22 10:07 naipofo

Currently there is no trigger causing a metadata update when a qualified beatmap becomes ranked. This will be added soon, which will resolve this issue. Could you confirm this is your only issue here?

peppy avatar Jul 31 '22 10:07 peppy

Well, everything else seems to be caused but the metadata not updating, like DateRanked being actually the qualified date despite the map being ranked already.

naipofo avatar Jul 31 '22 11:07 naipofo

Tried adding in some beatmaps through the listing in osu, through drag-and-drop, and through import from stable. They all seem to appear and sort as expected.

It's possible that the existing beatmaps didn't get updated to support the feature? I'm just guessing a possible reason.

FriendsNone avatar Jul 31 '22 11:07 FriendsNone

All beatmaps were supposed to be updated once after the feature was brought online, but I'll confirm this by checking your databases over the coming days. There may be an oversight with the state of certain beatmaps.

peppy avatar Jul 31 '22 11:07 peppy

The issue here is that the local cache actually doesn't contain the metadata required to populate beatmaps. So any batch imports (ie. from stable) are going to be populated with missing ranked date. Also, the background processing task is using the local cache where available, so it won't fill the data either.

I've got a working branch (https://github.com/ppy/osu/compare/master...peppy:osu:fill-missing-ranked-dates?expand=1) which will resolve this issue, but requires some extra data to be added to online.db to make it efficient (tracking https://github.com/ppy/osu-onlinedb-generator/issues/4).

peppy avatar Aug 01 '22 10:08 peppy

I might as well bump this issue since the "Date Submitted" sort as been added to 2022.902.0

I've just read (and seen) the changelog updates. I can redo the steps and send in the required files whenever I get some spare time.

FriendsNone avatar Sep 03 '22 15:09 FriendsNone

There's no need to bump this issue, it is already open and seemingly pending osu!-side changes to reprocess existing beatmaps and fill missing dates.

frenzibyte avatar Sep 03 '22 19:09 frenzibyte

As an update, the cache generator now includes this metadata, so this task can proceed.

peppy avatar Sep 08 '22 06:09 peppy

@peppy I believe this is still under your radar seeing that you're assigned? or was it only for the server-side changes.

frenzibyte avatar Sep 09 '22 14:09 frenzibyte

You're welcome to take it on if you want, won't be looking at it immediately.

peppy avatar Sep 09 '22 15:09 peppy

The problem still here, i wanted to play some old maps but when i enabled the filter, all the maps that was ranked more than one year ago disapear, even if they are selected

ranked_date_bug

Biokax avatar Dec 29 '22 13:12 Biokax

Resolved in https://github.com/ppy/osu/pull/22775, remaining issue is tracked in https://github.com/ppy/osu/issues/22416.

Joehuu avatar Apr 15 '24 20:04 Joehuu