osu icon indicating copy to clipboard operation
osu copied to clipboard

Show best rank badges for online scores at song select

Open roxandtol opened this issue 2 years ago • 5 comments

Type

Game behaviour

Bug description

On stable, you can see your best score submitted at the left of the beatmap, and in Lazer you can too, if you've submitted the score on that same platform, but if you check a beatmap you've played on pc on mobile, you can only see if you've set a score

Screenshots or videos

Score set on mobile: Screenshot_2022-07-17-04-38-25-80_25a1a32208bbcdc1d450b7aa854bb161

Score set on desktop: Screenshot_2022-07-17-04-23-40-28_25a1a32208bbcdc1d450b7aa854bb161

Version

2022.716.1

Logs

database.log network.log runtime.log performance.log

roxandtol avatar Jul 17 '22 02:07 roxandtol

If I'm correct, rank badges are stored in the Realm database which is not shared between platforms which would explain why it doesn't load initially. However, shouldn't the intended behaviour be to store the rank badge in the database if it retrieves an online score? Pretty sure this is how stable works and it seems most logical, would resolve this too

tsunyoku avatar Jul 17 '22 14:07 tsunyoku

We won't be doing it that way in lazer (it should already be in a good state before selecting the beatmap).

peppy avatar Jul 17 '22 14:07 peppy

How do you plan on storing badges on maps that you have an online score on if they aren't already cached in the database then?

tsunyoku avatar Jul 17 '22 14:07 tsunyoku

There will be a separate flow for that, as was done previously in stable. It needs to be batched and sent to the client.

peppy avatar Jul 17 '22 14:07 peppy

Ah, yeah I remember there being an endpoint in stable for it. Yeah, sounds like the good way to go about it.

tsunyoku avatar Jul 17 '22 14:07 tsunyoku