osu-wiki icon indicating copy to clipboard operation
osu-wiki copied to clipboard

Simplify approach rate formulas.md

Open Esnos33 opened this issue 8 months ago • 7 comments

Formulas in approach rate can be simplified by using equivalent transformations to much easier to understand form.

Self-check

Esnos33 avatar Apr 14 '25 09:04 Esnos33

Thank you for contributing to the osu! wiki.

Please take note of the following:

  • Make sure you've read this self-check checklist.

  • Translations that have not been reviewed by a native speaker will be merged after a minimum of 1 week. If there are no reviewers for your language, please mention it explicitly.

  • Refrain from spamming the Update branch button. A maintainer will do this before merging anyway.

  • Apply review suggestions in batches from the Files changed tab like this:

    Demo GIF

See the contribution guide for more information.

All changes are run through continuous integration checks, which provide automatic detection of common errors. If you need help with decrypting CI check error messages, or with any other issues, ask in the #osu-wiki channel on the osu! Discord server.

github-actions[bot] avatar Apr 14 '25 09:04 github-actions[bot]

I dunno, this doesn't do much for me.

peppy avatar Apr 16 '25 06:04 peppy

Instead of two tables there is only one table, formulas are easier to calculate in mind and it is clear when hitcircles fade in to 100%, I thought this is better.

Esnos33 avatar Apr 16 '25 14:04 Esnos33

I'm open to other opinions, but this differs from how we've always written this internally. I personally prefer not having constants change per instance.

peppy avatar Apr 17 '25 08:04 peppy

I agree with the fade-out edit, but would like to keep initial formulas as well -- while becoming easier to calculate, they partially lose the expressiveness

TicClick avatar Apr 17 '25 20:04 TicClick

If you like formulas, then maybe I can simplify formulas like this?

1200ms + 600ms * (5 - AR) / 5 -> 1200ms + 120ms * (5 - AR)
1200ms - 750ms * (AR - 5) / 5 -> 1200ms - 150ms * (AR - 5)

I really don't know why you need / 5

Esnos33 avatar Apr 17 '25 21:04 Esnos33

@peppy would that be fine by you?

TicClick avatar Jun 16 '25 10:06 TicClick