Incorrect displaying of "non-calculated scores"

[RichardKanshen]

When playing in lazer, some scores take time to calculate, and I can see that in-game, but the web browser says, that only personal best scores can give pp.

[peppy]

They don't take time to calculate. If anything, the in-game one is likely wrong.

Needs further investigation.

[peppy]

@nanaya Able to check on this? The pp values do seem to be populating correctly.

root@db-master:osu> select * from solo_scores_performance where score_id = 47472793;
| score_id | pp    |
|----------|-------|
| 47472793 | 12.76 |
1 row in set

[nanaya]

score displayed on the web is from osu_scores which for lazer is converted when the score is submitted and thus won't have the pp value

[peppy]

Hmmmmmmm I see. Did we have something in place previously to make this work? I swear lazer score pp values were showing in recent.

I guess it's safe to say this is resolved with the new table format implicitly.

[peppy]

@nanaya with the change to solo_scores, do we have new messaging for the case that pp is not calculated yet? the message in this issue in particular will not be correct going forward, i believe. at least not with how things work currently (every lazer score does get pp calculated, unless a fail i believe).

[nanaya]

I haven't added it. Shouldn't be too difficult.

[Swekka]

The bug is still present as far as I can tell.

[nanaya]

It's not fixable until the score storage system is switched to new one. If anything, the best tooltip it can currently give out is "pp value for recent scores from lazer client isn't available on web at the moment" (or something along that line).

The fix in the related PR is for when the system is finally migrated.

Actually, there's probably no hint at all whether or not the score is lazer so the tooltip might not even be possible.