osu-web icon indicating copy to clipboard operation
osu-web copied to clipboard

Scroll bar for tags

Open solstice23 opened this issue 2 years ago • 12 comments

resolves #5983

This shows all tags instead of the first 20 tags previously and adds a scroll bar if the tags will overflow.

before

image

after

image

I did it in a hacky way and probably need a better solution.

The example beatmap: https://osu.ppy.sh/beatmapsets/1656663#osu/3381471

solstice23 avatar Apr 10 '22 06:04 solstice23

Not sure how well this fits with the upcoming redesign of this page (#7899). Might be easier to implement as part of that PR, if it's not already the case.

peppy avatar Apr 11 '22 04:04 peppy

Still waiting on @arflyte for the response on new design as well (currently it's the same cutting off after certain number of tags).

nanaya avatar Apr 13 '22 03:04 nanaya

Most probably I'm going to introduce a hover popup for the new design to show extra tags.

arflyte avatar Apr 13 '22 04:04 arflyte

@arflyte Is this the final design for this tags popup? It's the only one I can find on the design

image

smoogipoo avatar Aug 01 '22 02:08 smoogipoo

Yes, it's the new design. I forgot to move it to the finalised design area. It is fixed now.

arflyte avatar Aug 01 '22 05:08 arflyte

Does that popup have a scrolling overflow of its own? The limit is 1000 characters. Or does it just keep expanding vertically until that limit?

smoogipoo avatar Aug 01 '22 05:08 smoogipoo

No scrolls. Expand till the limit.

arflyte avatar Aug 01 '22 05:08 arflyte

How does this popup work? Does it appear precisely in place so the tags already being displayed don't move? (but do change in colour/design?)

peppy avatar Aug 01 '22 06:08 peppy

As mentioned in the design, it pops up when the ellipsis is clicked; this allows the tags to be clicked easily. It appears next to the ellipsis. Clicking outside the popup will close the popup.

arflyte avatar Aug 01 '22 06:08 arflyte

Are you able to link the design? The link above takes me to a figma document with about 30 different screens.

peppy avatar Aug 01 '22 06:08 peppy

Unfortunately can't link the exact screen :( It's on the second screen at the top. Ignore everything underneath the red line.

arflyte avatar Aug 01 '22 06:08 arflyte

Here's a screenshot for those that don't want to fiddle with figma.

Safari 2022-08-01 at 06 34 41

peppy avatar Aug 01 '22 06:08 peppy

using #10030 instead

notbakaneko avatar Mar 28 '23 07:03 notbakaneko