osu-web icon indicating copy to clipboard operation
osu-web copied to clipboard

Negative grade counts on profiles

Open respektive opened this issue 4 years ago • 11 comments

The original issue https://github.com/ppy/osu-web/issues/7152 has been fixed by https://github.com/ppy/osu-web/pull/7996, but the negative counts still remain today. firefox_PoxO6rxWNs This was supposed to be fixed by a reprocess mentioned in this comment https://github.com/ppy/osu-web/issues/7152#issuecomment-891591192.

respektive avatar Dec 14 '21 19:12 respektive

Said reprocess has not yet been run. If you tell me the user ID here I can fix it for that specific case.

peppy avatar Dec 15 '21 01:12 peppy

I know about 2 users that currently have wrong grade counts, but there are probably many more that just aren't as obvious, because they didn't go into negative. So I'm not sure if it's that important to fix in this specific case, or if it might just be better to fix everyone with a full reprocess in the future.

Nonetheless I'll give you the two users i know about: https://osu.ppy.sh/users/5795337 https://osu.ppy.sh/users/14220975

respektive avatar Dec 15 '21 01:12 respektive

I've fixed those two users.

I'll keep this issue open to track the full reprocess task, which is a bit involved currently. Will likely be run after the migration of scores to a new structure, estimated to be done in the next month or two.

peppy avatar Dec 15 '21 02:12 peppy

As an update, I've fixed all negative counts now. The underlying issues causing this has also since been fixed.

A background process is running on all remaining users to ensure consistency, which will take several days. Let me know if anything comes up which requires further attention.

peppy avatar Feb 25 '22 06:02 peppy

Negative grade counts are still a problem. See this discord conversation. The profile in question is https://osu.ppy.sh/users/35641744, their A-rank count should be 1. I'm unsure about what the underlying issue is.

image

Some theorise this may be related to lazer/stable scores overwriting each other: https://discord.com/channels/188630481301012481/1097318920991559880/1239199661198413865.

As far as I know, you can get negative rank count since lazer pp release in two ways:

  • If you have the same rank as highest score on one map in lazer and stable, overwrite the score in lazer, then in stable (reduces the count 2 times instead of 1)
  • If you have different rank as highest score on one map in lazer and stable, overwrite the score only in lazer (removes a score the was not counted)

Susko3 avatar May 12 '24 13:05 Susko3

I don't it's clear what should be happening here, given that grades and even whether a score is your personal best can be different in lazer mode. from just a user perspective, it makes me want a separate set of these stats for lazer mode, but idk if that's too hard to maintain.

this also makes me wonder about how ranked score behaves if I pass a map first on lazer and then on stable...

cl8n avatar May 13 '24 04:05 cl8n

this also makes me wonder about how ranked score behaves if I pass a map first on lazer and then on stable...

Until we move all processing away from legacy systems, this is "best effort" aka undefined behaviour.

peppy avatar May 13 '24 05:05 peppy

Another case: https://osu.ppy.sh/users/18152711 image

hburn7 avatar Nov 18 '24 00:11 hburn7

Yes, it is still happening because we still haven't turned off broken legacy systems.

peppy avatar Nov 18 '24 01:11 peppy

same stuff with https://osu.ppy.sh/users/5795337 image

iSlodinxOsu avatar Nov 20 '24 19:11 iSlodinxOsu

Reopening as it is happening again, see https://github.com/ppy/osu/discussions/33589 / https://osu.ppy.sh/users/5795337.

Joehuu avatar Jun 09 '25 17:06 Joehuu