osu-web icon indicating copy to clipboard operation
osu-web copied to clipboard

Return UserRelation instead of UserCompact for friends API

Open cl8n opened this issue 4 years ago • 4 comments

resolves #7637

cl8n avatar Jun 21 '21 08:06 cl8n

It looks like this will need to be coordinated with lazer.

nanaya avatar Jun 21 '21 09:06 nanaya

yep. I'll wait for review on this first to get the API decided

I also removed the statistics include from the users in this response because I don't think it made sense to use the auth'd user's default mode (friends.read doesn't imply knowledge of that)... but lazer does use that info currently. should I add it back and require identify scope too or something?

cl8n avatar Jun 21 '21 21:06 cl8n

Fine to go ahead with this at your discretion (assuming this seems like a sane change - I think it does but haven't looked into it with too much thought).

Will coordinate the lazer side changes if/when this is merged.

peppy avatar Jun 23 '21 06:06 peppy

@cl8n still willing to apply the review to this one?

peppy avatar Jul 20 '21 08:07 peppy