osu-web icon indicating copy to clipboard operation
osu-web copied to clipboard

Excluding map tags from search doesn't work

Open Qunas101 opened this issue 8 months ago • 10 comments

Current behavior: putting -tag in search doesn't seem to affect the results in any way

Expected behavior: It should exclude all maps with tag from search

Example: https://osu.ppy.sh/beatmapsets?g=10&q=ranked%3D2023%20-electronic&s=ranked - same example as in #10916, only back then this prompt produced a few maps that weren't tagged with electronic by mapper. Now all maps with electronic are included

Qunas101 avatar Apr 07 '25 20:04 Qunas101

It seems to only work if sorted by Relevance, and even then it's only a suggestion, it just pushes 'excluded' beatmaps to bottom

Qunas101 avatar Apr 17 '25 16:04 Qunas101

Bumping in priority since this is a primary use of tags / search.

peppy avatar Apr 18 '25 06:04 peppy

-thing seem to work though? The link above explicitly selected electronic genre but otherwise there's no electronic in the tag.

nanaya avatar Apr 18 '25 06:04 nanaya

I think more details is needed, preferably with screenshots and links on the query and the result

(I did cursory check and the result seems correct)

nanaya avatar Apr 18 '25 06:04 nanaya

I think more details is needed, preferably with screenshots and links on the query and the result

Sure, I am an idiot for not including it in my reply

https://osu.ppy.sh/beatmapsets?l=8&q=ranked%3D2020%20-viking&s=ranked

Look at this example. Notice how the map with viking gets pushed to the bottom of the list. You can repeat the same process with other tags from maps in the example. Since maps are not removed from search completely, the sorting gets overwritten if you sort by anything other than Relevance.

Qunas101 avatar Apr 18 '25 07:04 Qunas101

So it's not "affect the results in any way" but more of it's still included just with lower relevancy (and thus not useful when sorted by anything else).

Apparently it's from adding the user tag query... removing the specific part hides it again

https://github.com/ppy/osu-web/blob/12c5c2d1a40a7c2e8325eb33b52a407f19cf9386/app/Libraries/Search/BeatmapsetSearch.php#L64-L69

nanaya avatar Apr 18 '25 07:04 nanaya

Also, beatmap search overlay on lazer experiences completely the same problem, but I assumed it works on the same web voodoo? So I didn't report it there

Qunas101 avatar Apr 18 '25 07:04 Qunas101

After some internal discussion, the intended behaviour is not to exclude the entire beatmap from search results if one of the diffs contains that tag even though the others do not. (Also generally applies to other attributes that are difficulty specific and not the whole beatmap).

Especially with generic query string filters that are more likely to unintentionally filter out results in non-obvious ways.

notbakaneko avatar Aug 19 '25 13:08 notbakaneko

This one talks about map tag though which is at beatmapset level...?

nanaya avatar Aug 19 '25 13:08 nanaya

Wait, which issue was I thinking of then 🤔

notbakaneko avatar Aug 20 '25 06:08 notbakaneko