osu-web icon indicating copy to clipboard operation
osu-web copied to clipboard

Leaderboard scores can be out of order when scores are drawed

Open maxowo opened this issue 1 year ago • 3 comments

Scores on this map are sorted by id instead of date set.

https://osu.ppy.sh/beatmapsets/259907#osu/593825

image image

It's the same on lazer (with classic mod).

maxowo avatar Oct 14 '24 12:10 maxowo

the sort could be changed to date, but it feels like the mapping between old and new score IDs should be monotonic in the first place...? I don't know enough details to comment on if that's possible to fix

cl8n avatar Oct 16 '24 00:10 cl8n

ID sorting is supposed to be feasible because of insert ID. there was an issue during the initial import which means that some scores are not in the correct order. This might be one of those cases. Will investigate.

peppy avatar Oct 16 '24 06:10 peppy

I'll add some notes I have on this. It's still on my radar.

Two score IDs in question: 234622848, 234622909

Running

SELECT id, legacy_score_id
from scores where beatmap_id = 593825 and ruleset_id = 0 and preserve = 1 and legacy_total_score = 46369 order by ended_at;

shows that this is definitely a broken case. I will need to write up a command to go through all beatmaps and fix these cases manually. Which means that some scores are going to have to change IDs (will be switched around between them).

Going to prioritise this as part of the “getting scores in a pristine state” effort.

peppy avatar Jan 17 '25 03:01 peppy