osu-web icon indicating copy to clipboard operation
osu-web copied to clipboard

Add platform issue tags

Open venix12 opened this issue 1 year ago • 8 comments

This adds buttons for "[osu!lazer]", "[osu!stable]", and "[osu!web]" thread title tagging, as of request of help forum moderators.

Uses separate const from regular tags as it doesn't have icon thing, and is supposed to be visible in thread names in the listing.

~~Also, genuinely had no idea for icons so they could be better possibly, though a mod-only feature so probably shouldn't matter as much 🤷.~~ It is text now.

In order: osu!lazer, osu!stable, osu!web image

venix12 avatar Aug 11 '24 22:08 venix12

Do these buttons actually fit? Can you provide a screenshot showing how this looks?

Also I don't think we need localisation for any of this.

peppy avatar Aug 12 '24 05:08 peppy

Updated the OP with a screenshot.

As for translations, it's built into issue tags workflow so is easier to just go that way rather than omitting it, it's only tooltips and success messages that get translated anyway, the tag itself doesn't.

venix12 avatar Aug 12 '24 09:08 venix12

is it possible to replace the icons with text? might make it more legible than almost-understandable icons. laz / stb / web maybe.

peppy avatar Aug 12 '24 10:08 peppy

Guess that works, done so.

venix12 avatar Aug 12 '24 14:08 venix12

also I think it would be good to combine the issue_tag_{tag} translations into just one set that takes the tag name as input, so that translators don't have to write a bunch of almost-duplicate translations either. but that's more like refactoring what was already here i guess

cl8n avatar Aug 13 '24 00:08 cl8n

feels like the tags should just be moved to a menu with this amount

nanaya avatar Aug 14 '24 05:08 nanaya

I wouldn't be against that.

peppy avatar Aug 14 '24 06:08 peppy

Making a new panel for the buttons would be nice, I wouldn't mind that. Though this design works fine as well since only a few people are using the buttons it really wouldn't matter either way.

Thanks for the quick work Venix, I appreciate it.

msmcculley avatar Aug 19 '24 16:08 msmcculley

I'm still adding the help thread tags manually, just asking because I don't really know github workflow, are we still going to add this at some point? I also would like to ask, is it possible for each icon to have their own color? So that the overview of help forum looks nice too. And, why no icons? Can we look for free ones?

By the way, we're currently using these tags:

  • question
  • osu!web
  • osu!lazer
  • osu!stable
  • technical support

tatitatai avatar Feb 01 '25 21:02 tatitatai