osu-web icon indicating copy to clipboard operation
osu-web copied to clipboard

Add datadog increment wrapper

Open notbakaneko opened this issue 1 year ago • 4 comments

Not sure if useful but needing to prefix most of the time $GLOBALS['cfg']['datadog-helper']['prefix_web'] seems repetitive 🤔 (and samplerate always being 1)

Renamed the thumbdonger.*counters to match the class name and removed the processed counter since its just the sum of the other 2.

notbakaneko avatar May 27 '24 08:05 notbakaneko

I wonder if we should just move everything (thumbs and chats) to osu.web. prefix

nanaya avatar May 27 '24 12:05 nanaya

I think that would be appreciated for consistency, except maybe for that one :thinking:

ThePooN avatar May 28 '24 12:05 ThePooN

it looks like osu-web is the only source now.

Also I think it's possible to modify the prefix temporarily if it's really needed.

nanaya avatar May 28 '24 13:05 nanaya

I propose renaming the thumbdonger.* stats to something else since the thumbnailer itself already sends its own stats...

notbakaneko avatar May 30 '24 08:05 notbakaneko

I guess we can look into renaming the metrics later and get this in first. Also maybe use named parameter and pass everything as is to the actual function?

nanaya avatar Jul 08 '24 07:07 nanaya