osu-web icon indicating copy to clipboard operation
osu-web copied to clipboard

include BeatmapPack id in API response

Open notbakaneko opened this issue 1 year ago • 1 comments

Doesn't make sense to exclude it anymore, since the id can be used for lookups and the response cursor uses the id instead of the tag

notbakaneko avatar Jan 03 '24 15:01 notbakaneko

Last I checked the id shouldn't be used anymore and lookup on id probably doesn't work. If anything the model should pretend the tag being primary key and sort on it instead?

(or maybe there's a different reason primary key is still pack_id but I don't think it warrants adding it to the response. cursors are supposed to be opaque anyway)

nanaya avatar Jan 03 '24 15:01 nanaya

Yeah, tag should always be used when interfacing externally.

nanaya avatar Apr 26 '24 13:04 nanaya