osu-web icon indicating copy to clipboard operation
osu-web copied to clipboard

Inconsistent "perfect combo" display in osu!taiko and osu!mania

Open Walavouchey opened this issue 1 year ago • 2 comments

Assuming that a green combo count on beatmap leaderboards is supposed to indicate the maximum possible combo, there are 3 cases where this is inconsistent. The causes are not obvious without checking the code or extensive testing in the game (nor are they documented).

There are similar inconsistencies with when the stable client displays Perfect on the results screen graph, but not sure if they are worth reporting separately.

Scores on maps with swells/dendens in osu!taiko are never marked "perfect"

Swells/dendens don't affect combo in stable ScoreV1 (they do in ScoreV2) and lazer. (This is the same for drumrolls but they don't have this issue regarding perfect combo.)

Example map (combo is not marked green):

image

Combo values greater than what Auto gets is possible in osu!mania

This seems to stem from hold notes giving a variable amount of combo in stable (even when not breaking combo) depending on hit timing. It is not a problem in lazer from what I can tell.

Example map (different combo counts are marked green):

image

"Perfect combo" in osu!mania requires zero 100s and zero 50s

Example map (scores with 100s or 50s are not marked green, regardless of combo):

image

This is due to the perfectCombo check here:

https://github.com/ppy/osu-web/blob/546c34b640163e171ae9f5ce1175d3901a39a92f/resources/js/utils/score-helper.ts#L40-L58

(There is a similar and more complicated check in stable.)

Not sure what legacy_perfect in that osu-web function corresponds to.

Walavouchey avatar Oct 25 '23 19:10 Walavouchey

perfect attribute for legacy (stable) scores is based solely on the database column value (which passed as legacy_perfect).

nanaya avatar Oct 26 '23 03:10 nanaya

perfect attribute for legacy (stable) scores is based solely on the database column value (which passed as legacy_perfect).

which to my recollection is provided by the stable client

peppy avatar Oct 26 '23 03:10 peppy