osu-tools Simulate osu!mania scores by accuracy and counts

Since osu!mania now uses accuracy -> pp system instead of score -> pp, mania score simulation needs to be updated in both osu-tools and osu-tools GUI. However, i heard that you want to revert this change so idk if this pull request is still relevant or not.

Oct 13 '22 08:10 kionell

Also, is there any reason why in ScoreInfoExtensions all 100's are Ok's, while everywhere else they are Good's?

Oct 13 '22 09:10 kionell

while everywhere else

Where do you mean?

Oct 14 '22 02:10 smoogipoo

OsuSimulateCommand as one of the cases

Oct 14 '22 10:10 Chiffario

Where do you mean?

Oh, at first i thought that this is the case for osu!taiko simulate command and how osu-web displays osu!taiko leaderboard counts, but then I read this and my questions are gone. The only confusing part that I found is in osu!standard simulate command. I mean this command uses greats (for 300's) and goods (for 100's) which is wrong (if i'm not missing anything), because from ScoreInfoExtensions we know that there are should be Ok's.

Oct 14 '22 10:10 kionell

At one point in time, osu! used to use Great/Good/Meh. These days every non-mania ruleset uses Great/Good/Ok. So the osu! simulate command (and potentially others) is out of date.

Oct 14 '22 10:10 smoogipoo