osu-stable-issues icon indicating copy to clipboard operation
osu-stable-issues copied to clipboard

Applying ScoreV2 to Ranked/Loved marathons isn't working

Open cl8n opened this issue 5 years ago • 12 comments

this map https://osu.ppy.sh/beatmaps/2157291 is not having scorev2 applied to all the scores, you can see here 17-20 were in v2 and the rest are v1

image

when you play the map, the scorev2 icon to added to the mods view on the top-right, but the scoring is still v1 if you didn't actually select the scorev2 mod in song select. this is with latest cuttingedge

also, since the v2 mod isn't set on any of these scores (including those bottom 4), watching the replay appears as v1

e: I talked to one of the people with V2 scores there and they said that they actually didn't have V2 selected in song select either. so I'm not sure how they managed to get V2 scoring while all these other guys didn't.

cl8n avatar May 31 '20 00:05 cl8n

Should be fixed in latest cutting edge (please confirm).

peppy avatar Jun 01 '20 02:06 peppy

looks like something about the deployment went wrong, the game tries to download an update on the main menu but it keeps getting 0518 (latest version before this). see confused comments on https://osu.ppy.sh/home/changelog/cuttingedge/20200518

cl8n avatar Jun 01 '20 23:06 cl8n

Correct, external issues I'm following up on that are possibly out of our control.

peppy avatar Jun 02 '20 00:06 peppy

As I've just managed to receive the latest update, I've briefly tested it out and it seems to be applying V2 correctly now. Tested nomod, NoFail and NFHTEZSO. With all the given scenarios, it's applying ScoreV2 as it should be.

huuishuu avatar Jun 02 '20 09:06 huuishuu

Thanks. Closing this issue for now. We'll push these changes out to beta/stable this week.

peppy avatar Jun 02 '20 09:06 peppy

will earlier builds of the game be able to submit here still? and should I wait for stable's update to move the map back into loved?

cl8n avatar Jun 05 '20 05:06 cl8n

Please wait a bit longer, will try and get beta/stable out today and add some backwards blocking logic.

peppy avatar Jun 05 '20 05:06 peppy

a6d0 Reposting from the #osu-loved discussion on the osu!dev server - multiplayer doesn't seem to be applying the ScoreV2 fix, as denoted by Tary's score on the Stream Compilation 201X map.

kOn8WIW

The fix works as intended in Single Player in every use-case scenario (except Auto) but not in Multiplayer.

EDIT: this map isn't an outlier. The same issue is occurring with every single map that breaks in V1. screenshot756 Here's Mashiro Iro Symphony Medley (82:43 length) that breaks in V1 still using ScoreV1 in multiplayer.

The icon for ScoreV2 appears when you start the map but it doesn't seem to use V2 unless explicitly selected.

huuishuu avatar Jun 11 '20 15:06 huuishuu

none of the online scores or replays have the V2 mod set, I think that's important for api users and UX on the leaderboard and score page. I'm assuming that if Auto fails to apply V2, that also means watching replays from the leaderboard in-game is still broken as well.

sorry this is a mess to fix, I'd usually try to test & report specific issues myself before moving map to Loved again, but there's not much I can test with a Pending map where score submission is involved

cl8n avatar Jun 12 '20 06:06 cl8n

setting the v2 flag is not possible due to database limitations. fixing that will take weeks of migration time :(. need to figure a better way to handle that but for now that's how it is. might be best to hold off loving for the time being.

peppy avatar Jun 12 '20 06:06 peppy

Would it be possible to have osu! block multiplayer scores in general on maps like this? Some sort of check that would prevent scores from submitting if it detects it's meant to be on ScoreV2? Though I'm not sure if something like that would work considering it has the possibility of breaking score submission in general.

huuishuu avatar Jun 12 '20 08:06 huuishuu

hack on hack on hack (no, that is not a valid option).

peppy avatar Jun 12 '20 08:06 peppy