osu-server-spectator `GracefulShutdownManager` is likely not working as expected

The original goal was to wait for all gameplay and multiplayer sessions to finish, but checking on staging the server was failing to shut down with this state:

Seems like something has regressed here

Mar 16 '25 10:03 peppy

ConnectionState seems to be the concurrent connection limiter. This particular change appears to have been done intentionally in https://github.com/ppy/osu-server-spectator/commit/54226e7ef67cb2ab14787b9346ab8528bca418a5, so cc/ @bdach

Mar 18 '25 08:03 smoogipoo

I'll look into it, but it seems weird that this surfaced after more than a year if it is that change.

Mar 18 '25 08:03 bdach

We've seen it waiting for 6 hours every shutdown for a long while but it's never really been a blocker, just a "hmm".

I open this because I managed to reproduce on staging with likely one user connected and idle. Should be pretty easy to repro if that's the case.

Mar 18 '25 09:03 peppy