osu-server-spectator icon indicating copy to clipboard operation
osu-server-spectator copied to clipboard

Dropping connection from spectator server mid-play results in truncated online replay

Open rvneXe opened this issue 1 year ago • 4 comments

Hi. I've downloaded a replay file from my profile to send it for someone, but it displays only a few seconds 'till the end. This zip file contains the original replay file, which game client gave me. And the replay file which I downloaded from osu.ppy.sh website. replayfiles.zip

rvneXe avatar Sep 19 '24 10:09 rvneXe

The replay retrieved from web contains frames from 658 frames from 141,060 to 152,154 ms, towards the latter end of the beatmap.

This implies the saved replay was truncated. Likely a failed connection to osu-server-spectator.

I'm not sure how we should be handling this yet. Either the whole play should be invalidated, or maybe the client needs to send catch-up data. (low priority cc/ @bdach for visibility on this).

peppy avatar Oct 04 '24 10:10 peppy

We could probably send the whole replay again after completion for validation?

smoogipoo avatar Oct 04 '24 10:10 smoogipoo

I swear I've seen this reported somewhere already and even recall reproducing a connection drop-out doing this but I can't find it now. Maybe a github account deletion sent it to the shadow realm.

bdach avatar Oct 04 '24 10:10 bdach

We could probably send the whole replay again after completion for validation?

Maybe yeah. It's not a high prio item since this should happen quite rarely, but requires some discussion on validation concerns (ie. whether we want to use real-time packets as score validation piece).

peppy avatar Oct 04 '24 10:10 peppy