osu-framework icon indicating copy to clipboard operation
osu-framework copied to clipboard

SDL spamming unsupported operation logs on macOS

Open frenzibyte opened this issue 1 month ago • 2 comments

Been occurring since https://github.com/ppy/osu-framework/pull/6668, due to the API not being supported on macOS:

https://github.com/user-attachments/assets/2330a761-9125-4972-942f-caa634b022e2

frenzibyte avatar Dec 05 '25 00:12 frenzibyte

Could you put a breakpoint in logOutput() to confirm that it's the SDL_GetWindowBordersSize call causing the error. Look at the stack trace.

I'm not sure if there's a way to discover if an SDL API is available for a given platform, the best thing we can do is stop calling it when we get an error that the operation is not supported. (Can SDL report a call as unsupported, but later in the app's lifetime, the operation works? Probably not.)

I've also seen "That operation is not supported" in Android logs. It's probably harmless, some operation doesn't work, but it's not important on Android.

Susko3 avatar Dec 05 '25 09:12 Susko3

I already did that, that's how I confirmed it's SDL_GetWindowBordersSize to begin with before mentioning the PR here. I've also read the SDL source code and confirmed there's no implementation for macOS/Cocoa, hence making SDL_GetWindowBordersSize call SDL_Unsupported() somewhere in the codebase.

Can we increase the SDL log level filter to "info" or something so that these kind of verbose logs are avoided?

frenzibyte avatar Dec 05 '25 14:12 frenzibyte