osu-framework icon indicating copy to clipboard operation
osu-framework copied to clipboard
verified publisher icon ppy

Expose spites and drawnodes in `BufferedContainer`, `TextureAnimation` and `Video` to make it easier to inherit and tinker with

Open Uncomfy opened this issue 1 year ago • 2 comments

This PR is a companion to https://github.com/ppy/osu/pull/30391

It contains changes for sprites and drawnodes, which are necessary to be able to replace shaders (and interact with them) in storyboards and beatmap backgrounds.

Uncomfy avatar Oct 22 '24 16:10 Uncomfy

See https://github.com/ppy/osu/pull/30391#discussion_r1811207718. I don't get the "redrawing the internal children" part here. With the osu!-side PR as context, you'll only redraw every time the dim level/colour is changed, so that shouldn't be an issue?

frenzibyte avatar Oct 22 '24 18:10 frenzibyte

Reading https://github.com/ppy/osu/pull/30391#discussion_r1815242461, I can understand why this is required now.

frenzibyte avatar Oct 26 '24 04:10 frenzibyte