osu-framework
osu-framework copied to clipboard
Tracking issue for changes/fixes in latest SDL version
Fixed by https://github.com/libsdl-org/SDL/commit/6c962177272c6a2ce684e4298b40c25ebdd1ac74:
- https://github.com/ppy/osu-framework/issues/4159
- https://github.com/ppy/osu/issues/12228
- https://github.com/ppy/osu-framework/issues/4050 (probably fixed by something else)
- [x] #5136
Fixed by https://github.com/libsdl-org/SDL/commit/5ff42438e36e98c9d72ac70f5f5ce4599b96d3d2:
- https://github.com/ppy/osu-framework/issues/4055
- relevant: https://github.com/ppy/osu-framework/issues/1679
- SDL no longer sends
SDL_WINDOWEVENT_ENTERandSDL_WINDOWEVENT_LEAVEevents if any button is pressed when the mouse leaves and enters the window. This introduces a nasty bug withMouseHandlerwhere relative mode won't be re-enabled if the mouse leaves and enters the window while holding down any buttons. This is by design. - [x] #5163
Fixed by https://github.com/libsdl-org/SDL/pull/5398:
- https://github.com/ppy/osu/issues/17231
- This PR introduces a bug with our IME handling, as SDL will now send multiple
SDL_TextInputEvents when the text is longer than 32 characters. Should be easy to fix, either delay resetting ofrecentImeResult, or match the SDL text with our composition text usingstring.Contains. - [x] https://github.com/ppy/osu-framework/pull/5141
- [ ] update
ResetImeto useSDL_ClearCompositionon non-windows platforms.
General:
- [ ] Reach out to users affected by https://github.com/ppy/osu/issues/17381 and check if it's fixed.
Things to note
https://github.com/flibitijibibo/SDL2-CS is not updated to the latest SDL, and there is no open PR on their side. We can set the hints, but we won't be able to use SDL_ClearComposition.
With the three PRs, we should be ready for an SDL bump. SDL2-CS was also recently bumped to 2.0.22. Making use of new APIs, such as SDL_ClearComposition(), can be added later.
We may want for https://github.com/libsdl-org/SDL/issues/5572 to be fixed, as noticed on discord.
I'll look to do a bump today or tomorrow if no one else beats me
@Susko3 1.0.518-alpha is now propagating to nuget. I'll leave it in your hands to consume it in the order of your choosing.