Pruner-Zero icon indicating copy to clipboard operation
Pruner-Zero copied to clipboard

Missing the parameter X for W_metric?

Open cquxl opened this issue 1 year ago • 2 comments

In prune.py, find out if W_metric is missing X,should it be engine.forward(W,G,X)?

1722996516687

cquxl avatar Aug 07 '24 02:08 cquxl

In fact, these code is only used for inference, which is correspond to the equation found in our paper.

As you can see, X is just part of the search space, and we actually have tried it before. If you want to search further, you can modify the forward function of engine to incorporate the X.

pprp avatar Aug 19 '24 02:08 pprp

But your engine.forward has 3 arguments, W,G,X. Do you mean I need to modify the forward function, i.e. remove X? Because I get an error when running your code directly: TypeError: GPTree.forward() missing 1 required positional argument: 'X'. If engine.forward only has two arguments, would it be best to clarify this on github so we can get fair and correct results?

cquxl avatar Sep 11 '24 13:09 cquxl

same problem I encouter !

lybbill avatar Nov 21 '24 12:11 lybbill

same problem

hhhhain avatar Nov 22 '24 07:11 hhhhain

Thanks for you caring. I have fixed the code in https://github.com/pprp/Pruner-Zero/commit/db70134ed7d4c521a57060fd698f353d04268429.

Please let me know if there are any further bugs.

pprp avatar Nov 25 '24 09:11 pprp