Philippe PRADOS
Philippe PRADOS
@eyurtsev May be, you can consider another may other [PR 20735](https://github.com/langchain-ai/langchain/pull/20735) ?
@eyurtsev The promise of the constructor, with the `create_extension` parameter, is to guarantee that the extension is added before the APIs are used. Since this promise cannot be kept in...
@eyurtsev, can you approval the workflow? I can check if all the code passes the CI.
Hello @eyurtsev I've aligned the code with your similar requests for `SQLChatMessageHistory`. Currently, `SQLChatMessageHistory` cannot be reviewed, as there are [bugs in the base sources](https://github.com/langchain-ai/langchain/actions/runs/9249913171/job/25442525728?pr=22065), when linting around `docs/scripts/arxiv_references.py` or...
@eyurtsev I locked with "1 change requested", but I can't find where the change request is. Can you help me?
@eyurtsev I made the mistake of doing a rebase while a review was in progress. This seems to block the process. There's a ‘1 change requested’ request that I can't...
Yes. The idea is to use the same approach as for the other integrations with sqlalchemy, exploiting the connection pool and sharing sessions if possible. the vectorstore proposes ``` connection:...
@eyurtsev I propose a [PR](https://github.com/langchain-ai/langchain/pull/22065) to resolve this problem.
A patch is being applied [here](https://github.com/langchain-ai/langchain/pull/22065)